Swe 24 show pending transactions and allow cancel #16
+130
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ahm11003
commented
Apr 9, 2019
ahm11003
commented
- Added functionality for "cancel payment" button on eligible recent pending transactions
- we require the `accountAlias` of the current account in order to cancel a payment - changed the type of dictionary passed through Transactions functionality to support getting the account to transaction details, so we can ultimate use to cancel a pending payment
- we need to have the transaction locally so we can pass its members to our API to cancel payment - added outlet for cancel button
- this will help us provide a better user experience and aesthetic in regards to showing “cancel payment” flow
- also remove boilerplate template code
rrk12005
approved these changes
Apr 9, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.